Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc for SPM #6790

Merged
merged 21 commits into from
Aug 11, 2021
Merged

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Aug 2, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

In version5.2, we try to ban the feature for baseline evolution. So we need to forbid to open the switch.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

TiDB pull#26333
TiDB pull#26403
TiDB pull#26340
TiDB pull#26139

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 2, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2021
@Reminiscent
Copy link
Contributor Author

/cc @eurekaka

@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. v5.2 This PR/issue applies to TiDB v5.2. and removed missing-translation-status This PR does not have translation status info. labels Aug 2, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2021
sql-plan-management.md Outdated Show resolved Hide resolved
sql-plan-management.md Outdated Show resolved Hide resolved
sql-plan-management.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

TomShawn commented Aug 5, 2021

/rebase

sql-plan-management.md Outdated Show resolved Hide resolved
sql-plan-management.md Outdated Show resolved Hide resolved
Co-authored-by: Kenan Yao <cauchy1992@gmail.com>
@TomShawn TomShawn requested a review from eurekaka August 6, 2021 02:46
@TomShawn TomShawn added the status/PTAL This PR is ready for reviewing. label Aug 9, 2021
sql-plan-management.md Outdated Show resolved Hide resolved
select * from t;

-- 使用 explain 语句查看 SQL 的执行计划,通过查看 warning 信息确认查询所使用的 Binding
explain select * from t;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain verbose?


该语句使用系统变量 [last_plan_from_binding](https://docs.pingcap.com/zh/tidb/stable/system-variables#last_plan_from_binding-%E4%BB%8E-v40-%E7%89%88%E6%9C%AC%E5%BC%80%E5%A7%8B%E5%BC%95%E5%85%A5) 显示上一条执行的语句所使用的执行计划是否来自 binding 的执行计划。

另外,当我们使用 explain 语句查看 SQL 的查询计划时,如果该 SQL 使用了 Binding,explain 语句会产生 warning,我们可以通过查看 warning 了解 SQL 使用了哪一条 Binding。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain verbose?

sql-plan-management.md Outdated Show resolved Hide resolved
sql-plan-management.md Outdated Show resolved Hide resolved
sql-plan-management.md Outdated Show resolved Hide resolved
sql-plan-management.md Outdated Show resolved Hide resolved
sql-plan-management.md Outdated Show resolved Hide resolved
sql-plan-management.md Outdated Show resolved Hide resolved
sql-plan-management.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Aug 11, 2021
Reminiscent and others added 7 commits August 11, 2021 12:50
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Aug 11, 2021
sql-plan-management.md Outdated Show resolved Hide resolved
sql-plan-management.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 11, 2021
sql-plan-management.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 883d037

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2021
@ti-chi-bot ti-chi-bot merged commit 25b785e into pingcap:master Aug 11, 2021
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Aug 11, 2021
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.2 This PR/issue applies to TiDB v5.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants